Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: 5620 far field data #5632

Merged
merged 11 commits into from
Jan 14, 2025
Merged

FIX: 5620 far field data #5632

merged 11 commits into from
Jan 14, 2025

Conversation

Devin-Crawford
Copy link
Contributor

Description

Resolve issue when numeric values are past for frequencies to Hfss.get_antenna_data()

Issue linked

Close #5620

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Devin-Crawford
Update Docstring
87114b6 
There was an error in the Examples docstring for
farfield_visualization.py
@Devin-Crawford
Fix error in Hfss.get_antenna_data
933286d 
When numeric frequency values were passed, they were
not corrected to consider frequency units.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (8d696d9) to head (822b487).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5632      +/-   ##
==========================================
- Coverage   85.26%   85.26%   -0.01%     
==========================================
  Files         152      152              
  Lines       60939    60944       +5     
==========================================
+ Hits        51958    51962       +4     
- Misses       8981     8982       +1

Devin-Crawford and others added 3 commits January 8, 2025 11:20
@Devin-Crawford
Fix errors causing UT failure
040d808 
- hfss.py: Check if setup name
  exists before trying to add a
  new setup.
- Get solution frequency using get_solution_data for Unit test instead of passing a number.
- Fix error in tick marks in maptlotlib.py
@pre-commit-ci
CHORE: Auto fixes from pre-commit.com hooks
b460f23 
For more information, see https://pre-commit.ci
@Devin-Crawford
Merge branch 'main' into fix/5620_far_field_data
0ea16b0
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 13, 2025 12:54
@Samuelopez-ansys Samuelopez-ansys merged commit 334d730 into main Jan 14, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/5620_far_field_data branch January 14, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug located in get_antenna_data
2 participants
@Devin-Crawford @Samuelopez-ansys